[PATCH] D58073: [GlobalISel][NFC]: Add interface to reserve memory in GISelWorklist

Aditya Nandakumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 13 13:43:29 PST 2019


aditya_nandakumar marked an inline comment as done.
aditya_nandakumar added inline comments.


================
Comment at: include/llvm/CodeGen/GlobalISel/GISelWorkList.h:94
     auto It = WorklistMap.find(I);
     if (It == WorklistMap.end()) return; // Not in worklist.
 
----------------
paquette wrote:
> I think that in standard LLVM code style, the return should be on a newline. (Or, that's what clang-format does on my end anyway)
> 
> ```
> if (It == WorklistMap.end())
>     return;
> ```
Clang format does not do that for me. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58073/new/

https://reviews.llvm.org/D58073





More information about the llvm-commits mailing list