[PATCH] D57904: [llvm-objdump] Allow short options to be grouped

[Matthew Voss via Phabricator via llvm-commits]

ormris marked an inline comment as done.
ormris added inline comments.


================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:110
 static cl::list<std::string>
 DisassembleFunctions("df",
                      cl::CommaSeparated,
----------------
rupprecht wrote:
> ormris wrote:
> > rupprecht wrote:
> > > This conflicts with -d and -f when grouped args are allowed
> > Is renaming this option possible? It doesn't seem to fit with the naming scheme...
> Yep, it should be fine to rename it to "disassemble-functions" or something equally reasonable. You'll have to update test/tools/llvm-objdump/X86/disasm-specific-funcs.test.
Sounds good. I'll add that to the patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57904/new/

https://reviews.llvm.org/D57904