[PATCH] D58194: [DebugInfo] add SectionedAddress to DebugInfo interfaces.
    Alexey Lapshin via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Wed Feb 13 13:18:47 PST 2019
    
    
  
alexey.lapshin added a comment.
David, thank you for the review. I would address all points. two major points ;
1. If it is OK to left tools with UNDEF value and TODO comment - then I am also OK with this and would remove changes for sancov.
2. As to having two SectionedAddress structures. I was thinking that existing  SectionedAddress structure is local for Dwarf sources. So that Dwarf sources could be independend from another sources. But if it is not the case - then It would be better to leave only one SectionedAddress structure defined at Object/ObjectFile.h  So if it is OK I will just remove  SectionedAddress from DWARFSection.h
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58194/new/
https://reviews.llvm.org/D58194
    
    
More information about the llvm-commits
mailing list