[PATCH] D57857: [PowerPC] custom lower `v2f64 fpext v2f32`

Amy Kwan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 13 09:45:08 PST 2019


amyk added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:9553
+    }
+    SDValue newOp=DAG.getNode(Op0.getOpcode(), SDLoc(Op0), MVT::v4f32,
+                              NewLoad[0], NewLoad[1],
----------------
Spacing between `newOp=DAG...` into `newOp = DAG...` maybe?


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.h:407
 
+      /// Custom expend v4f32 to v2f64.
+      FP_EXTEND_LHW,
----------------
saghir wrote:
> `expand` maybe?
I think maybe the correct word is `extend` since the line below is `FP_EXTEND_LHW`? 


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57857/new/

https://reviews.llvm.org/D57857





More information about the llvm-commits mailing list