[PATCH] D55301: RegAlloc: Allow targets to split register allocation

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 13 09:33:14 PST 2019

arsenm marked an inline comment as done.
arsenm added a comment.

In D55301#1393260 <https://reviews.llvm.org/D55301#1393260>, @rampitec wrote:

> In D55301#1393065 <https://reviews.llvm.org/D55301#1393065>, @arsenm wrote:
> > ping
> Pass the filter to PreRewrite.

I'm not sure what good that would do as it doesn't do anything now

Comment at: lib/CodeGen/RegAllocFast.cpp:1350
+  std::function<bool(const TargetRegisterInfo &TRI,
+                     const TargetRegisterClass &RC)> Ftor, bool ClearVirtRegs) {
+  return new RegAllocFast(Ftor, ClearVirtRegs);
qcolombet wrote:
> Could we have just one createFastRegisterAllocator with default arguments?
> (Also ClearVirtReg should disappear per my other comment IMO).
The RegAllocRegistry requires the type to be the no-argument function pass constructor. I could change that, but then all would have the ClearVirtRegs argument or not



More information about the llvm-commits mailing list