[PATCH] D58187: Teach DTU to recalculate DT/PDT automatically when EntryBB is changed

[Jakub Kuderski via Phabricator via llvm-commits]

kuhar added a comment.

Seems like a nice improvement!



================
Comment at: llvm/include/llvm/Analysis/DomTreeUpdater.h:245
+  BasicBlock *EntryBlock = nullptr;
+  bool NeedRecalculate = false;
   SmallVector<DominatorTree::UpdateType, 16> PendUpdates;
----------------
Maybe NeedToRecalculate?


================
Comment at: llvm/include/llvm/Analysis/DomTreeUpdater.h:259
+  /// Returns true if available trees are recalculated.
+  bool checkEntryBlockChange();
+
----------------
checkIfRootChanged?


================
Comment at: llvm/include/llvm/Analysis/DomTreeUpdater.h:264
+  /// awaiting deletion immediately.
+  void internalrecalculate();
+
----------------
internalRecalculate


================
Comment at: llvm/include/llvm/Support/GenericDomTree.h:252
   friend struct DomTreeBuilder::SemiNCAInfo<DominatorTreeBase>;
+  friend class DomTreeUpdater;
 
----------------
Why do we need this? maybe it would be better to expose/use some other function? Tree root can be accessed with the `getRoots` function.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58187/new/

https://reviews.llvm.org/D58187