[PATCH] D57881: [DTU] Refine the document of mutation APIs [NFC] (PR40528)

[Chijun Sima via Phabricator via llvm-commits]

NutshellySima added inline comments.


================
Comment at: llvm/include/llvm/Analysis/DomTreeUpdater.h:148
+  /// submitted. }
   void insertEdgeRelaxed(BasicBlock *From, BasicBlock *To);
 
----------------
kuhar wrote:
> I thought that we still need the relaxed version in order to make JumpThreading code happy? Should it be deprecated?
I think it is not needed to preserve the relaxed version because JT also submits invalid updates when calling applyUpdates(). And I believe [[ https://reviews.llvm.org/D58170 | D58170 ]] can solve most of the problems in JT by making use of the extra information inferred from the fact that JT only submits updates that didn't happen but never submits updates that are already applied.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57881/new/

https://reviews.llvm.org/D57881