[PATCH] D58132: lld/elf: When demangling symbols, surround demangled symbol with quotes and include mangled symbol as well

[Nico Weber via Phabricator via llvm-commits]

thakis added a comment.

In D58132#1395055 <https://reviews.llvm.org/D58132#1395055>, @ruiu wrote:

> It looks like always showing both mangled and demangled names makes the output a bit too large. I'm a little skeptical how useful it is. Where did you find it useful?


I found the error message in comment 0 of https://bugs.chromium.org/p/chromium/issues/detail?id=930883 a bit difficult to read and wished I had the mangled symbol too. I'm used to the lld/coff output, I suppose. (It'd be nice if they were consistent in their output too.) The mangled name is usually shorter than the demangled one, so maybe it's not so bad. I agree output length is a concern though. I figured it's early in 9.0, we could land this and see if we like it, and if we don't, then remove it again (in both elf and coff). But in the end it's your call.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58132/new/

https://reviews.llvm.org/D58132