[PATCH] D58176: [ARM] Ensure we update the correct flags in the peephole optimiser
Sjoerd Meijer via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 13 06:45:19 PST 2019
SjoerdMeijer accepted this revision.
SjoerdMeijer added a comment.
This revision is now accepted and ready to land.
LGTM, with one nit inline.
Perhaps wait a day in case someone else has comments.
================
Comment at: lib/Target/ARM/ARMBaseInstrInfo.cpp:2828
- // The single candidate is called MI.
- if (!MI) MI = SubAdd;
+ // If we found a SubAdd, use it as it will be "closer"
+ if (SubAdd) {
----------------
You've already put it in quotes, but perhaps you can describe closer a bit better.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58176/new/
https://reviews.llvm.org/D58176
More information about the llvm-commits
mailing list