[PATCH] D58175: [llvm-readobj] Dump GNU_PROPERTY_X86_ISA_1_{NEEDED, USED} notes in .note.gnu.property

[George Rimar via Phabricator via llvm-commits]

grimar added a comment.

In D58175#1396181 <https://reviews.llvm.org/D58175#1396181>, @MaskRay wrote:

> There is no output for AVX512BW, as I'm not sure enumerating every bit would be useful. Every bit can be tested individually, but that is tedious and makes the test hard to read (there would just be a long line duplicating the ISA names in the source code). I think that checking the 2 most significant bits and the 2 least significant bits should be good enough.


I am not suggesting to test each bit individually but suggesting to prepare an input that would test all of them. I.e. a case where all bits are set.
I think that makes sense because we want to test printing of all of the bits actually.
That is how we test them in LLD and in tests for tools like llvm-objdump.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58175/new/

https://reviews.llvm.org/D58175