[PATCH] D58174: [yaml2obj] - Do not skip zeroes blocks if there are relocations against them.
George Rimar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 13 06:43:40 PST 2019
grimar added a comment.
In D58174#1396199 <https://reviews.llvm.org/D58174#1396199>, @MaskRay wrote:
> This behavior is reasonable, and is what GNU objdump has:
>
> 0000000000000000 <.rodata>:
> ...
> 0: R_X86_64_64 *ABS*
> a: R_X86_64_64 *ABS*
>
>
> It doesn't use our 8-zeroes heuristic, though.
FWIW, I did not try to follow the objdump. I think we can do better :)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58174/new/
https://reviews.llvm.org/D58174
More information about the llvm-commits
mailing list