[PATCH] D58041: [Backend] DBG_CALLSITE & DBG_CALLSITEPARAM instr handling
David Stenberg via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 13 03:08:45 PST 2019
dstenb added inline comments.
================
Comment at: lib/CodeGen/StackColoring.cpp:963
for (MachineBasicBlock &BB : *MF)
- for (MachineInstr &I : BB) {
+ for (auto I = BB.instr_begin(), E = BB.instr_end(); I != E; I++) {
// Skip lifetime markers. We'll remove them soon.
----------------
dstenb wrote:
> The iterator does seem to be invalidated here (or am I overlooking something?), so you should be able to use `BB.instrs()` here instead.
Gah, "does _not_".
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58041/new/
https://reviews.llvm.org/D58041
More information about the llvm-commits
mailing list