[PATCH] D58175: [llvm-readobj] Dump GNU_PROPERTY_X86_ISA_1_{NEEDED, USED} notes in .note.gnu.property
George Rimar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 13 06:12:25 PST 2019
grimar added a comment.
You do not need to do cosmetic changes in the same patch where you do functional changes generally.
i.e. renaming of the `pr_data` -> `PrData` is LGTM and it can be committed as NFC change that does not need a review.
Regarding the rest of the patch, seems it is not fully covered with a test case? I see no output for `AVX512BW` for example?
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58175/new/
https://reviews.llvm.org/D58175
More information about the llvm-commits
mailing list