[PATCH] D57686: [ARM CGP] Fix ConvertTruncs

Wed Feb 13 06:06:50 PST 2019

SjoerdMeijer added inline comments.

================
Comment at: test/CodeGen/ARM/CGP/arm-cgp-casts.ll:636
+
+; CHECK-LABEL: replace_trunk_with_mask
+; CHECK: udiv
----------------
Looks like this isn't checked... that is, if I am not mistaken, the CHECK prefix doesn't occur in the run lines?

I was initially expecting something with an AND here, but the whole point of course is that this gets optimised away? So just nitpicking on this test then.... Perhaps a CHECK udiv, followed by CHECK-NEXT mls to make this explicit, and/or possibly a CHECK-NOT and?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57686/new/

https://reviews.llvm.org/D57686