[PATCH] D51215: Fix misfolding of IRBuilder.CreateICmp(int_ty X, bitcast (float_ty Y) to int_ty)
Sanjay Patel via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 13 05:33:44 PST 2019
spatel added inline comments.
Comment at: unittests/IR/IRBuilderTest.cpp:679
+ // fp->int bitcast.
+ auto F32TimesTwo = Builder.CreateAdd(F32, F32);
+ auto I32 = Builder.CreateBitCast(F32TimesTwo, I32Type);
> spatel wrote:
> > This means that IRBuilder has a bug/opportunity to be stricter? How did we create an integer add with FP operands?
> Oops, that should be CreateFAdd. It looks like this would trigger an assertion on a NDEBUG build. But should I keep this test if it's redundant with the IR test case you added?
No - we can remove this test now. Please rebase/update with the new IR test.
CHANGES SINCE LAST ACTION
More information about the llvm-commits