[PATCH] D58157: Stop enabling clang-tools-extra automatically when clang is in LLVM_ENABLE_PROJECTS

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 13 04:58:43 PST 2019


thakis added a comment.

In D58157#1395762 <https://reviews.llvm.org/D58157#1395762>, @mehdi_amini wrote:

> In D58157#1395716 <https://reviews.llvm.org/D58157#1395716>, @rnk wrote:
>
> > I think we have consensus,
>
>
> Based on three comments in a revision? Seems strange to me.
>  I don't really care about this, so do whatever you want, but I would expect that "consensus" means an actual wider discussion (i.e. llvm-dev + cfe-dev).


Please cite said discussion for when you added this, as requested above. Else, I think this has seen more discussion than the change that is undoing. It also has the support of several folks very actively working on clang and clang-tools-extra.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58157/new/

https://reviews.llvm.org/D58157





More information about the llvm-commits mailing list