[compiler-rt] r353820 - tsan: update check_analyze.sh

Diana Picus via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 13 04:06:02 PST 2019


On Wed, 13 Feb 2019 at 12:34, Diana Picus <diana.picus at linaro.org> wrote:
>
> Hi Dmitry,
>
> I have reverted r353817 in r353939, since it broke some of the
> buildbots. Does this need to be reverted as well while we investigate?

I think the buildbots have answered my question. Reverted in r353942.

> Thanks,
> Diana
>
> On Tue, 12 Feb 2019 at 11:17, Dmitry Vyukov via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
> >
> > Author: dvyukov
> > Date: Tue Feb 12 02:18:27 2019
> > New Revision: 353820
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=353820&view=rev
> > Log:
> > tsan: update check_analyze.sh
> >
> > Update numbers after 353817.
> > This was extensively benchmarked in https://reviews.llvm.org/D54889
> >
> >
> > Modified:
> >     compiler-rt/trunk/lib/tsan/check_analyze.sh
> >
> > Modified: compiler-rt/trunk/lib/tsan/check_analyze.sh
> > URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/tsan/check_analyze.sh?rev=353820&r1=353819&r2=353820&view=diff
> > ==============================================================================
> > --- compiler-rt/trunk/lib/tsan/check_analyze.sh (original)
> > +++ compiler-rt/trunk/lib/tsan/check_analyze.sh Tue Feb 12 02:18:27 2019
> > @@ -36,17 +36,11 @@ check() {
> >
> >  for f in write1 write2 write4 write8; do
> >    check $f rsp 1
> > -  check $f push 1
> > -  check $f pop 8
> > -done
> > -
> > -for f in read1; do
> > -  check $f rsp 1
> >    check $f push 2
> >    check $f pop 16
> >  done
> >
> > -for f in read2 read4 read8; do
> > +for f in read1 read2 read4 read8; do
> >    check $f rsp 1
> >    check $f push 3
> >    check $f pop 24
> >
> >
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at lists.llvm.org
> > https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits


More information about the llvm-commits mailing list