[PATCH] D58112: [llvm-readobj] Dump GNU_PROPERTY_X86_FEATURE_2_{NEEDED, USED} notes in .note.gnu.property

Wed Feb 13 03:46:38 PST 2019

grimar added inline comments.

================
Comment at: llvm/trunk/tools/llvm-readobj/ELFDumper.cpp:3653
   raw_string_ostream OS(str);
+  uint32_t pr_data;
+  auto DumpBit = [&](uint32_t Flag, StringRef Name) {
----------------
grimar wrote:
> MaskRay wrote:
> > grimar wrote:
> > > nit: `pr_data` violates the LLVM variables naming style which says they should be uppercase.
> > > Perhaps it could be `PrData`.
> > I know but `pr_data` is used by the ABI. Keeping the name unchanged makes it easy for reference and validation purpose. The ELF naming is used in several other places. This is a simple case so I have no strong preference:)
> I do not think ABI has a higher priority over LLVM coding style.
At least you should not be able to find something like that in LLVM coding style documents :]

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58112/new/

https://reviews.llvm.org/D58112