[PATCH] D57584: [DebugInfo][DAG] Reduce SelectionDAGs reordering of variables referring to Arguments

Wed Feb 13 03:11:14 PST 2019

jmorse marked an inline comment as done.
jmorse added a comment.

The filtering from r353735 happily makes the sparc test change un-necessary.

I also tested whether filtering parameters so that they can't take VReg SDDbgValues is necessary any more. Removing the if block around the relevant code still makes DebugInfo/X86/sdag-split-arg.ll change behaviour. This doesn't surprise me: how fast-isel interacts with SelectionDAG is a mystery to me.

================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:4944

+  // FIXME: this function may hoist inlined function arguments across blocks.
+
----------------
bjope wrote:
> Is this FIXME still relevant after https://reviews.llvm.org/rL353735 ? Maybe it can be removed after rebase?
Removed FIXME, r353735 does indeed add sufficient filtering,

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57584/new/

https://reviews.llvm.org/D57584