[PATCH] D58112: [llvm-readobj] Dump GNU_PROPERTY_X86_FEATURE_2_{NEEDED, USED} notes in .note.gnu.property

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 13 01:47:37 PST 2019


grimar added inline comments.


================
Comment at: llvm/trunk/tools/llvm-readobj/ELFDumper.cpp:3653
   raw_string_ostream OS(str);
+  uint32_t pr_data;
+  auto DumpBit = [&](uint32_t Flag, StringRef Name) {
----------------
nit: `pr_data` violates the LLVM variables naming style which says they should be uppercase.
Perhaps it could be `PrData`.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58112/new/

https://reviews.llvm.org/D58112





More information about the llvm-commits mailing list