[PATCH] D54978: Move the SMT API to LLVM

[Nico Weber via Phabricator via llvm-commits]

thakis added a comment.

In D54978#1395136 <https://reviews.llvm.org/D54978#1395136>, @brzycki wrote:

> The following patch:
>
>   diff --git a/llvm/cmake/modules/CrossCompile.cmake b/llvm/cmake/modules/CrossCompile.cmake
>   index bc3b210f018..0c30b88f80f 100644
>   --- a/llvm/cmake/modules/CrossCompile.cmake
>   +++ b/llvm/cmake/modules/CrossCompile.cmake
>   @@ -53,6 +53,7 @@ function(llvm_create_cross_target_internal target_name toolchain buildtype)
>            -DLLVM_DEFAULT_TARGET_TRIPLE="${TARGET_TRIPLE}"
>            -DLLVM_TARGET_ARCH="${LLVM_TARGET_ARCH}"
>            -DLLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN="${LLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN}"
>   +        -DLLVM_ENABLE_Z3_SOLVER="${LLVM_ENABLE_Z3_SOLVER}"
>            ${build_type_flags} ${linker_flag} ${external_clang_dir}
>        WORKING_DIRECTORY ${LLVM_${target_name}_BUILD}
>        DEPENDS CREATE_LLVM_${target_name}
>


Independent of the rest of the discussion, this patch should be part of the reland, to make sure that explicitly turning off Z3 works reliably. Thanks for coming up with that, and thanks everyone for the good discussion here :)


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54978/new/

https://reviews.llvm.org/D54978