[PATCH] D58157: Stop enabling clang-tools-extra automatically when clang is in LLVM_ENABLE_PROJECTS

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 12 17:31:11 PST 2019

thakis added a comment.

In D58157#1395666 <https://reviews.llvm.org/D58157#1395666>, @mehdi_amini wrote:

> What is the motivation to change this now?
> > also it's impossible to build clang without clang-tools-extra in the monorepo while that's there.
> That was the intent.
> This was added with the expectation (and somehow consensus in the discussions I had at the time about the move to git) that the distinction with clang-tools-extra was mostly artificial and that we should have them "part of clang".

I don't think there's agreement on this. Several clang folks I talked to on IRC are against this (eg AaronBallman ErichKeane myself), as were several people at the last dev meeting (forgot the names though) – with the argument that clang/ should be the compiler proper, and extra tools should be in extra tools.

I don't remember this being discussed on cfe-dev – did I miss it? Do you have a link?

> In the case of the monorepo, the plan was that we would move the clang-tools-extra folder from the top-level to be nested under clang after we move to GitHub. In the same idea, at the time the plan was that if we had gone with multiple repos instead of a monorepo, there wouldn't have been a separate clang-tools-extra repo.
>  Not building them would then be an opt-in, the same way as LLVM_BUILD_TOOLS is controlled for example.



More information about the llvm-commits mailing list