[PATCH] D57938: [WebAssembly] Update MC for bulk memory

Derek Schuff via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 12 16:44:39 PST 2019


dschuff added a comment.

Without the context of MC here there's no indication what kind of flags the `.init_flags` directive refers to. Maybe call it `init_segment_flags`?



================
Comment at: llvm/lib/Target/WebAssembly/MCTargetDesc/WebAssemblyTargetStreamer.h:20
 #include "llvm/MC/MCStreamer.h"
+#include "llvm/MC/MCSectionWasm.h"
 #include "llvm/Support/MachineValueType.h"
----------------
You don't need to include this here, you can just forward declare `class MCSectionWasm` down on line26 with the others.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57938/new/

https://reviews.llvm.org/D57938





More information about the llvm-commits mailing list