[PATCH] D58093: [CMake][runtimes] Use variables rather than ":" delimiters

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai added inline comments.
Herald added a subscriber: jdoerfert.


================
Comment at: llvm/runtimes/CMakeLists.txt:392
     foreach(component ${LLVM_RUNTIME_DISTRIBUTION_COMPONENTS})
-      if(NOT "${target_name}:${target_name}-${component}" IN_LIST extra_targets)
-        list(APPEND ${name}_extra_targets
-          "${target_name}:${target_name}-${component}"
-          "${target_name}:${target_name}-install-${component}")
-      endif()
+      set(install-${component}-${name} ${component})
+      set(${component}-${name} ${component})
----------------
Super nit: the other block seems to have the install target line after the regular target line, so it'd be nice to be consistent.


================
Comment at: llvm/runtimes/CMakeLists.txt:394
+      set(${component}-${name} ${component})
+      list(APPEND ${name}_extra_targets ${target_name}-install-${component} ${target_name}-${component})
     endforeach()
----------------
I'm confused. Should this be something like the following instead?

  list(APPEND ${name}_extra_targets install-${component}-${name} ${component}-${name})


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58093/new/

https://reviews.llvm.org/D58093