[PATCH] D58157: Stop enabling clang-tools-extra automatically when clang is in LLVM_ENABLE_PROJECTS

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 12 16:41:50 PST 2019

thakis added a comment.

In D58157#1395593 <https://reviews.llvm.org/D58157#1395593>, @smeenai wrote:

> Can you also add clang-tools-extra to LLVM_ALL_PROJECTS?

Good point, done. Thanks!

> I'm personally in favor of this (explicit is better than implicit), but there are some bots that assume clang implies clang-tools-extra. @phosek ran into this with some Fuchsia bots, for example.

That's fine, we can update the bots :)

(I'm also open to other approaches that allow us to build clang without clang-tools-extra in the monorepo, but since not everybody agrees with that comment there, this seemed like the simplest and most explicit approach.)



More information about the llvm-commits mailing list