[PATCH] D56394: [Driver] Error out when using an older CPU than Haswell with x86_64h

Francis Visoiu Mistrih via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 12 16:37:43 PST 2019


thegameg marked an inline comment as done.
thegameg added inline comments.


================
Comment at: lib/Driver/ToolChains/Arch/X86.cpp:24
+namespace {
+bool isAMDMarch(StringRef March) {
+  return llvm::StringSwitch<bool>(March)
----------------
craig.topper wrote:
> Why are we blocking all AMD CPUs?
The arch `x86_64h` is used for Intel 64-bit Haswell in mach-o. We are trying to validate wether the `-march=` passed along with `-target x86_64h-apple-darwin` is Intel, and at least Haswell.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56394/new/

https://reviews.llvm.org/D56394





More information about the llvm-commits mailing list