[PATCH] D54978: Move the SMT API to LLVM
Dominic Chen via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Feb 12 12:32:34 PST 2019
ddcc added a comment.
In D54978#1395268 <https://reviews.llvm.org/D54978#1395268>, @brzycki wrote:
> I think I found why others are struggling to recreate this issue. I did not have the package `z3/bionic` installed. This provides the `/usr/bin/z3` executable which `llvm/cmake/modules/FindZ3.cmake` relies upon to determine the correct `Z3_VERSION_STRING`.
Yeah, that's what I meant by best-effort only. Due to upstream Z3's design, without the binary, there is no easy way to retrieve the current installed version, so when I originally wrote the Z3 integration, it seemed fine to let the version check pass. Given the issues that have come up, it might make more sense to at least emit a warning, or explicitly fail if the version can't be determined, and prompt the user to install the binary.
CHANGES SINCE LAST ACTION
More information about the llvm-commits