[PATCH] D57979: [dsymutil] Don't clone empty CUs

[Frederic Riss via Phabricator via llvm-commits]

friss added inline comments.
Herald added a subscriber: jdoerfert.


================
Comment at: llvm/tools/dsymutil/CompileUnit.cpp:60
+  if (NewUnit) {
+    NextUnitOffset += 11 /* Header size */;
     NextUnitOffset += NewUnit->getUnitDie().getSize();
----------------
aprantl wrote:
> @friss Do you remember why that comment is there? Isn't a header without a DW_TAG_compile_unit invalid DWARF?
Must have been because dsymutil-classic was doing it. I don't recall any good reason we would generate this.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57979/new/

https://reviews.llvm.org/D57979