[PATCH] D55325: [RISCV] Add assembler support for LA pseudo-instruction

Alex Bradbury via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 12 08:13:40 PST 2019


asb accepted this revision.
asb added a comment.
This revision is now accepted and ready to land.

Looks good to me - thanks. I like the refactoring to introduce `emitAuipcInstPair`. Nit: a comment next to its declaration (along the lines of the comments for neighbouring helper declarations) would be useful.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55325/new/

https://reviews.llvm.org/D55325





More information about the llvm-commits mailing list