[PATCH] D54978: Move the SMT API to LLVM

[Nico Weber via Phabricator via llvm-commits]

thakis added a comment.
Herald added a subscriber: jdoerfert.

>> If so, I don't understand why the default setting is important to you and why this doesn't work for you. (I don't disagree with the default being off, I'm just confused why things don't work for you.)
> 
> As I have stated several times, the CMake option `-D LLVM_OPTIMIZED_TABLEGEN=ON` spawns a sub-command of CMake and **is required for the break to occur**. I don't know how to make this any more clear: if you build with optimized tablegen, it breaks. I strongly suspect an interaction between LLVM's top-level CMake and the TableGen one but I haven't had time to debug it down to the exact cause.
> 
> It is important to me because the detection of the correct version of Z3 is imprecise, at best.  If a Z3 library is found  I have no way to guarantee a build I run will not attempt to include the library.

Got it now, sorry about being dense.

mikhail.ramalho: My guess is that we need to pass on LLVM_OPTIMIZED_TABLEGEN to the child cmake invocation in http://llvm-cs.pcc.me.uk/cmake/modules/CrossCompile.cmake#50 (like we pass on a few other variables) to fix this.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54978/new/

https://reviews.llvm.org/D54978