[PATCH] D57231: [LoopSimplifyCFG] Pay respect to LCSSA when removing dead blocks

[Max Kazantsev via Phabricator via llvm-commits]

mkazantsev marked an inline comment as done.
mkazantsev added inline comments.


================
Comment at: include/llvm/Transforms/Utils/BasicBlockUtils.h:44
+void DeleteDeadBlock(BasicBlock *BB, DomTreeUpdater *DTU = nullptr,
+                     bool DontDeleteUselessPHIs = false);
 
----------------
mkazantsev wrote:
> fedor.sergeev wrote:
> > mkazantsev wrote:
> > > fhahn wrote:
> > > > nit: How about KeepUselessPHIs, or KeepSingleValuePHIs, which is a bit more descriptive.
> > > I used exactly the same name as existing function `removePredecessor` has. We can make a follow-up refactoring to change them all, but so far I'd prefer to keep things uniform.
> > I also find this name very confusing...
> I will rename all its occurrences in a follow-up.
https://reviews.llvm.org/rL353801


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57231/new/

https://reviews.llvm.org/D57231