[PATCH] D56782: [PPC64] Preserve LocalEntry when linking

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: ELF/Target.h:182
+// GlobalEntryToLocalEntry offset.
+static inline uint8_t getPPC64GlobalEntryToLocalEntryBits(uint8_t StOther) {
+  return StOther & 0xE0;
----------------
MaskRay wrote:
> Perhaps add a comment referencing Arch/PPC64.cpp `getPPC64GlobalEntryToLocalEntryOffset`
> 
> The 3 most significant bits of st_other are used by OpenPOWER ABI.
Sorry, the comment should be near line 2003 :)


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56782/new/

https://reviews.llvm.org/D56782