[PATCH] D54975: [analyzer] Generalised the SMT state constraints

Douglas Yung via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 11 17:23:45 PST 2019

dyung added a comment.

In D54975#1394044 <https://reviews.llvm.org/D54975#1394044>, @dyung wrote:

> In D54975#1394002 <https://reviews.llvm.org/D54975#1394002>, @dyung wrote:
> > In D54975#1393783 <https://reviews.llvm.org/D54975#1393783>, @mikhail.ramalho wrote:
> >
> > > > To be clear, this patch breaks compilation with Visual Studio 2015. Running tests requires that the code can be built, so no I didn't run the tests.
> > >
> > > Maybe I didn't express myself very clearly: if you change it to `ConstraintSMTType`, do the tests pass?
> > >
> > > If so, I don't see why not pushing the fix. Unfortunately, I don't have Windows to test it.
> >
> >
> > I can give it a try. But just to be clear, the fix is to change ConstraintSMTTy on line 22 to ConstraintSMTType? Would line 23 require a similar change, or is it fine as it currently is?
> I can answer my own question, both seem to need updating. I am building/testing now.

Build and test passed for me with Visual Studio 2015 and on Linux. Should I submit the fix?




More information about the llvm-commits mailing list