[PATCH] D56782: [PPC64] Preserve LocalEntry when linking

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 11 16:31:53 PST 2019


ruiu added a comment.
Herald added a project: LLVM.

Sorry for the belated response. I missed this one for some reason.

Can you add a test?



================
Comment at: ELF/SyntheticSections.cpp:2003
+    if (Config->EMachine == EM_PPC64)
+      ESym->st_other |= getPPC64GlobalEntryToLocalEntryBits(Sym->StOther);
+
----------------
I think you need to define a new function that is so trivial. I'd hardcode `& 0xe0` with an explanation what that is.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56782/new/

https://reviews.llvm.org/D56782





More information about the llvm-commits mailing list