[PATCH] D54978: Move the SMT API to LLVM

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 11 16:13:34 PST 2019

thakis added a comment.

> In D54978#1393552 <https://reviews.llvm.org/D54978#1393552>, @ddcc wrote:
>> The likely reason for this versioning problem is that the current versioning implementation in FindZ3.cmake is best-effort only.
> Thank you @ddcc for this explanation. If that's the case I'd really prefer if `LLVM_ENABLE_Z3_SOLVER` was explicit opt-in and defaulted to `OFF` regardless of what `find_package` returned.

Do you understand why the default matters for you? You seem to explicitly disable the setting, and you still get Z3 as part of your build. Did you make a clean build dir before turning it to OFF? If so, I don't understand why the default setting is important to you and why this doesn't work for you. (I don't disagree with the default being off, I'm just confused why things don't work for you.)

  rC Clang



More information about the llvm-commits mailing list