[PATCH] D58026: LLD: Preserve ABI version during linking ELF

Konstantin Zhuravlyov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 11 15:03:33 PST 2019

kzhuravl added a comment.

In D58026#1393837 <https://reviews.llvm.org/D58026#1393837>, @ruiu wrote:

> The interpretation of ABI version of an ELF object file depends on the target machine type. For example, we can think of a target that allows a mix of version X and version Y objects let a linker to create a shim between cross-version function call. At least most ABIs don't define anything about the ABI version, so it is perhaps most natural to ignore the field at all, unless you are linking for a specific target in which the ABI version has a special meaning. Therefore, I'd think code that works only for AMDGPU target is better.

Ok, sounds fair. Do you want me to incorporate your patch into this review?



More information about the llvm-commits mailing list