[PATCH] D58026: LLD: Preserve ABI version during linking ELF

Konstantin Zhuravlyov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 11 14:46:14 PST 2019


kzhuravl added a comment.

In D58026#1393777 <https://reviews.llvm.org/D58026#1393777>, @ruiu wrote:

> I quickly hacked up this patch: https://gist.github.com/rui314/f3cd508b6cbbde763fc13bc6190d7505  Does this look good?


The patch you linked will work. Alternatively, can you take a look at the updated patch I just posted?

Is there any reason to not implement this for all targets? In your link you specifically check for AMDGPU...

Also it seems like OSABI is also suffering from the problem you described in your first comment. Is this intentional?

Thanks


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58026/new/

https://reviews.llvm.org/D58026





More information about the llvm-commits mailing list