[PATCH] D58058: llvm-objdump -macho -objc-meta-data should print body of protocols in protolist

Michael Trent via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 11 14:22:39 PST 2019


mtrent added a comment.

In D58058#1393262 <https://reviews.llvm.org/D58058#1393262>, @pete wrote:

> LGTM.
>
> Looks like we can have print_protocol_list64_t also call the new print_protocol_64_t, but that can be done in a later NFC commit.


Thanks Pete! I took a swipe at it and realized fixing the formatting is a bit more work than we want to bite off right now. But I realized also that objdump isn't printing the imp pointer any more (I think this regressed in March?) so I put it back. The lit test ought to shore up objdump against further regressions.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58058/new/

https://reviews.llvm.org/D58058





More information about the llvm-commits mailing list