[PATCH] D58005: Recover elf32-bigmips and elf32-powerpc support in LLD

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: lld/ELF/Driver.cpp:132
           .Case("elf32lriscv", {ELF32LEKind, EM_RISCV})
-          .Case("elf32ppc", {ELF32BEKind, EM_PPC})
+          .Cases("elf32ppc", "elf32ppclinux", {ELF32BEKind, EM_PPC})
           .Case("elf64btsmip", {ELF64BEKind, EM_MIPS})
----------------
Do you know where `elf32ppclinux` came from? Is this really correct to handle it as a synonym for `elf32ppc`?


================
Comment at: lld/ELF/ScriptParser.cpp:398
       .Case("elf64-x86-64", {ELF64LEKind, EM_X86_64})
-      .Case("elf32-tradbigmips", {ELF32BEKind, EM_MIPS})
+      .Cases("elf32-tradbigmips", "elf32-bigmips", {ELF32BEKind, EM_MIPS})
       .Case("elf32-ntradbigmips", {ELF32BEKind, EM_MIPS})
----------------
Ditto -- do you know if this correct to handle `elf32-bigmips` as a synonym for `elf32-tradbigmips`?


================
Comment at: lld/test/ELF/emulation-ppc.s:107-108
+# RUN: llvm-mc -filetype=obj -triple=powerpc-unknown-linux %s -o %tppc32
+# RUN: ld.lld -m elf32ppc %tppc32 -o %t2ppc32
+# RUN: llvm-readobj -file-headers %t2ppc32 | FileCheck --check-prefix=PPC32 %s
+# RUN: ld.lld %tppc32 -o %t3ppc32
----------------
Please test `-m elf32ppclinux` as well.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58005/new/

https://reviews.llvm.org/D58005