[PATCH] D57968: [LICM] Cap the clobbering calls in LICM.
Alina Sbirlea via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Feb 11 13:32:55 PST 2019
asbirlea marked an inline comment as done.
asbirlea added inline comments.
Comment at: include/llvm/Transforms/Utils/LoopUtils.h:115
AliasSetTracker *, MemorySSAUpdater *, ICFLoopSafetyInfo *,
- bool, OptimizationRemarkEmitter *);
+ bool, int &, OptimizationRemarkEmitter *);
> Nit: I'm OK with this as is, but if we grow another MSSA-related optimization limit/counter, please wrap the MSSA-related bits into some sort of options struct (a bit in spirit like `llvm::ObjectSizeOpts`, but we'd also be tracking the mutable `EnableLicmCapCounter`/etc in it)
Noted, and I agree! I considered adding this in this patch, actually.
Additional refactoring may help somewhat, since the only user of sinkRegion and hoistRegion is LICM. We'd still needs these bits wrapped up for canSinkAndHoist which is used in LoopSink.
Leaving it as a separate cleanup for now.
CHANGES SINCE LAST ACTION
More information about the llvm-commits