[PATCH] D57968: [LICM] Cap the clobbering calls in LICM.

Mon Feb 11 11:16:27 PST 2019

george.burgess.iv added a comment.

Thanks for this!

One currently-actionable nit from me

================
Comment at: include/llvm/Transforms/Utils/LoopUtils.h:115
                 AliasSetTracker *, MemorySSAUpdater *, ICFLoopSafetyInfo *,
-                bool, OptimizationRemarkEmitter *);
+                bool, int &, OptimizationRemarkEmitter *);

----------------
Nit: I'm OK with this as is, but if we grow another MSSA-related optimization limit/counter, please wrap the MSSA-related bits into some sort of options struct (a bit in spirit like `llvm::ObjectSizeOpts`, but we'd also be tracking the mutable `EnableLicmCapCounter`/etc in it)

================
Comment at: lib/Transforms/Scalar/LICM.cpp:119
+static cl::opt<int> EnableLicmCap(
+    "enable-licm-cap", cl::init(100), cl::Hidden,
+    cl::desc("Enable imprecision in LICM in pathological cases, in exchange "
----------------
nit: enable sounds pretty bool-y for an int. Can we swap to `licm-mssa-optimization-cap` (or similar)?

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57968/new/

https://reviews.llvm.org/D57968