[PATCH] D56203: [IRReader] Expose getLazyIRModule

Teresa Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 11 10:37:38 PST 2019

tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.

The original change predates my involvement with LLVM, but it sounds like the only reason was just cleanup since it wasn't used elsewhere. I don't see any issue with adding this interface (similar to how we have exposed both parseIR and parseIRFile).

LGTM with a request below.

Comment at: include/llvm/IRReader/IRReader.h:35
+/// reader to optionally enable lazy metadata loading.
+std::unique_ptr<Module> getLazyIRModule(std::unique_ptr<MemoryBuffer> Buffer,
+                                        SMDiagnostic &Err, LLVMContext &Context,
Please add a comment that this takes ownership of the Buffer. That is one important change since the original modification that made this static.



More information about the llvm-commits mailing list