[PATCH] D57702: [SelectionDAGBuilder] Add restrictions to EmitFuncArgumentDbgValue

[Bjorn Pettersson via Phabricator via llvm-commits]

bjope marked 2 inline comments as done.
bjope added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:5005
+    bool VariableIsFunctionInputArg = Variable->isParameter() &&
+        DL->getInlinedAt() == nullptr;
+    bool IsInPrologue = SDNodeOrder == LowestSDNodeOrder;
----------------
aprantl wrote:
> we usually write this as `!DL->getInlinedAt()`
Yes, I'll fix that before commit.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:5041
+      if (ArgNo >= FuncInfo.DescribedArgs.size())
+        FuncInfo.DescribedArgs.resize(ArgNo + 1);
+      else if (!IsInPrologue && FuncInfo.DescribedArgs.test(ArgNo))
----------------
aprantl wrote:
> I assume the in-between elements are zeroed out by default?
Yes, but I can add an explicit argument to resize to indicate that we want to initialize new bits to "false" to avoid relying on default arguments.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57702/new/

https://reviews.llvm.org/D57702