[PATCH] D57231: [LoopSimplifyCFG] Pay respect to LCSSA when removing dead blocks

Fedor Sergeev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 11 05:33:36 PST 2019

fedor.sergeev accepted this revision.
fedor.sergeev added a comment.
This revision is now accepted and ready to land.

LGTM, but please, schedule those followups discussed here.

Comment at: include/llvm/Transforms/Utils/BasicBlockUtils.h:44
+void DeleteDeadBlock(BasicBlock *BB, DomTreeUpdater *DTU = nullptr,
+                     bool DontDeleteUselessPHIs = false);
mkazantsev wrote:
> fhahn wrote:
> > nit: How about KeepUselessPHIs, or KeepSingleValuePHIs, which is a bit more descriptive.
> I used exactly the same name as existing function `removePredecessor` has. We can make a follow-up refactoring to change them all, but so far I'd prefer to keep things uniform.
I also find this name very confusing...



More information about the llvm-commits mailing list