[PATCH] D56587: Introduce DW_OP_LLVM_convert

[Markus Lavin via Phabricator via llvm-commits]

markus marked an inline comment as done.
markus added inline comments.


================
Comment at: include/llvm/CodeGen/DIE.h:685
 public:
+  MCSymbol *Label = nullptr;
   DIE() = delete;
----------------
aprantl wrote:
> It seems excessive to burden every DIE object with an extra 8 bytes for something we'll only need on a handful of basic type DIEs. Would it be possible to store this in a DenseMap on the side instead?
I agree and it does seem like the most logical place for such a DenseMap would be inside the CU. It is not clear however how to make that available to `AsmPrinter::emitDwarfDIE` without violating the current interfaces.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56587/new/

https://reviews.llvm.org/D56587