[PATCH] D57939: Refactor RelocVisitor and fix computation of SHT_RELA-typed relocation entries

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Feb 10 17:38:02 PST 2019


MaskRay added a comment.

In D57939#1391941 <https://reviews.llvm.org/D57939#1391941>, @dblaikie wrote:

> In D57939#1391531 <https://reviews.llvm.org/D57939#1391531>, @MaskRay wrote:
>
> > `RelocVisitor.h -> RelocationResolver.cpp` there are so many differences that git doesn't consider it a rename.
>
>
> Right - what I'm asking is if you could undo/not apply the file name change in this revision, so the patch/review is easier to read, possibly? (you could undo the file name change & upload a new revision for this review - then the delta might be smaller/easier to read)


I just created https://reviews.llvm.org/D58020 for exposition purposes. This patch and D58020 <https://reviews.llvm.org/D58020> have no functional difference but D58020 <https://reviews.llvm.org/D58020> puts all changes together in RelocVisitor.h


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57939/new/

https://reviews.llvm.org/D57939





More information about the llvm-commits mailing list