[PATCH] D57317: [DAGCombine] Deduplicate addcarry node using commutativity.

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Feb 10 10:19:48 PST 2019


RKSimon added a comment.

In D57317#1390578 <https://reviews.llvm.org/D57317#1390578>, @deadalnix wrote:

> @RKSimon This can go now, but has no effect in isolation in any of the test cases I have, mainly because DAGCombine is fairly powerless when faced with addcarry as most of the work involve 'deep' patterns. Do you think I should land anyways ?


Unless you can add test coverage now I think this will have to wait.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57317/new/

https://reviews.llvm.org/D57317





More information about the llvm-commits mailing list