[PATCH] D33841: [clang-tidy] redundant keyword check

Eugene Zelenko via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Feb 9 13:32:19 PST 2019


Eugene.Zelenko added a comment.

Please mention new check in Release Notes.



================
Comment at: clang-tidy/readability/RedundantExternCheck.cpp:55
+} // namespace clang
\ No newline at end of file

----------------
Please add new line.


================
Comment at: clang-tidy/readability/RedundantExternCheck.h:5
+//
+// This file is distributed under the University of Illinois Open Source
+// License. See LICENSE.TXT for details.
----------------
Please update license statement. See current Clang-tidy code as example. Same in other files.


================
Comment at: docs/clang-tidy/checks/readability-redundant-extern.rst:6
+
+This checker removes the redundant `extern` keywords from code.
+
----------------
Please remove //This checker//. Language constructs should be enclosed in ``.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D33841/new/

https://reviews.llvm.org/D33841





More information about the llvm-commits mailing list