[PATCH] D58007: Recover elf32-bigmips support in LLD

vit9696 via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Feb 9 11:51:09 PST 2019


vit9696 created this revision.
vit9696 added reviewers: lld, ruiu.
Herald added subscribers: llvm-commits, atanasyan, arichardson, sdardis, emaste.
Herald added a reviewer: espindola.
Herald added a project: LLVM.

This fixes a 7.0 -> 8.0 regression when parsing OUTPUT_FORMAT("elf32-bigmips"); directive in ldscripts.

I request this to be backported to LLD 8.0, as it is a regression breaking ldscripts that worked fine with LLD 7.0.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D58007

Files:
  lld/ELF/ScriptParser.cpp


Index: lld/ELF/ScriptParser.cpp
===================================================================
--- lld/ELF/ScriptParser.cpp
+++ lld/ELF/ScriptParser.cpp
@@ -395,7 +395,7 @@
       .Case("elf64-powerpc", {ELF64BEKind, EM_PPC64})
       .Case("elf64-powerpcle", {ELF64LEKind, EM_PPC64})
       .Case("elf64-x86-64", {ELF64LEKind, EM_X86_64})
-      .Case("elf32-tradbigmips", {ELF32BEKind, EM_MIPS})
+      .Cases("elf32-tradbigmips", "elf32-bigmips", {ELF32BEKind, EM_MIPS})
       .Case("elf32-ntradbigmips", {ELF32BEKind, EM_MIPS})
       .Case("elf32-tradlittlemips", {ELF32LEKind, EM_MIPS})
       .Case("elf32-ntradlittlemips", {ELF32LEKind, EM_MIPS})


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D58007.186129.patch
Type: text/x-patch
Size: 661 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190209/232c8ea3/attachment.bin>


More information about the llvm-commits mailing list