[PATCH] D57988: [GlobalISel] Regex the opcodes in unit test to fix non-deterministic ordering

Aditya Nandakumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Feb 9 08:44:17 PST 2019


aditya_nandakumar accepted this revision.
aditya_nandakumar added a comment.
This revision is now accepted and ready to land.

In D57988#1391452 <https://reviews.llvm.org/D57988#1391452>, @mgrang wrote:

> legalize-ext-csedebug-output.mir fails in a reverse iteration build because the OpcodeHitTable is a DenseMap and is iterated to print CSEInfo. We could have copied OpcodeHitTable to a vector and sorted it before iteration. Maybe that would be an overkill. I saw this comment in the test that we could regex the opcodes. Do we care about the order of the CSEInfo opcodes?


Sorry this test is brittle. This change should have been done in the first place as there were a couple of build failures already. Thanks.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57988/new/

https://reviews.llvm.org/D57988





More information about the llvm-commits mailing list